FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix pre-push after rebase by taliastocks · Pull Request #3427 · pre-commit/pre-commit · GitHub

/ pre-commit Public

Fix pre-push after rebase - #3427

Open
taliastocks wants to merge 5 commits into
pre-commit:mainfrom
taliastocks:patch-1
ConversationCommits (5)ChecksFiles changed
Open

Fix pre-push after rebase#3427
taliastocks wants to merge 5 commits into
pre-commit:mainfrom
taliastocks:patch-1

Conversation

taliastocks commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Attempt to fix #2424, which has been marked as a duplicate of #860 (does not fix all of the latter).

Update hook_impl.py
e7959ec 
Attempt to fix pre-commit#2424, which has incorrectly been marked as a duplicate of pre-commit#860

taliastocks commented Mar 14, 2025

Copy link
Copy Markdown
Author

Happy to fix/add tests if the approach seems reasonable

taliastocks mentioned this pull request Mar 14, 2025
Open
taliastocks commented Mar 14, 2025
View reviewed changes
Comment thread pre_commit/commands/hook_impl.py Outdated
taliastocks commented Mar 14, 2025
View reviewed changes
Comment thread pre_commit/commands/hook_impl.py Outdated
taliastocks commented Mar 14, 2025
View reviewed changes
Comment thread pre_commit/commands/hook_impl.py Outdated

asottile commented Mar 14, 2025

Copy link
Copy Markdown
Member

"incorrectly marked as a duplicate" you're really not starting strong with trying to convince me to take your patch. please don't tell me how to run my project

taliastocks commented Mar 14, 2025

Copy link
Copy Markdown
Author

"incorrectly marked as a duplicate" you're really not starting strong with trying to convince me to take your patch. please don't tell me how to run my project

My apologies. I appreciate your efforts, and we chose to use this project because of them.

jdarpinian commented Sep 20, 2025

Copy link
Copy Markdown

This is a good change, it fixes a real issue. I tested it locally and it works for me.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better support for diff calculation for rebase workflow

3 participants

Back | FazBrowse Home | New Git URL