FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sort-simple-yaml: read and write YAML files as UTF-8 by 0xacee · Pull Request #1276 · pre-commit/pre-commit-hooks · GitHub

  1. pre-commit
  2. pre-commit-hooks

Repository navigation

sort-simple-yaml: read and write YAML files as UTF-8 #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xacee wants to merge 1 commit into from
Conversation 1 Commits 1 Checks 7 Files changed
Closed

sort-simple-yaml: read and write YAML files as UTF-8 #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion pre_commit_hooks/sort_simple_yaml.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def main(argv: Sequence[str] | None = None) -> int:
retval = 0

for filename in args.filenames:
with open(filename, 'r+') as f:
with open(filename, 'r+', encoding='utf-8', newline='') as f:
lines = [line.rstrip() for line in f.readlines()]
new_lines = sort(lines)

Expand Down
12 changes: 12 additions & 0 deletions tests/sort_simple_yaml_test.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@ def test_integration_good_bad_lines(tmpdir, bad_lines, good_lines, retval):
assert [line.rstrip() for line in f.readlines()] == good_lines


def test_non_ascii_content_roundtrip(tmpdir):
file_path = os.path.join(str(tmpdir), 'foo.yaml')

with open(file_path, 'w', encoding='utf-8') as f:
f.write('b: caf\u00e9\n\na: \u2603\n')

assert main([file_path]) == RETVAL_BAD

with open(file_path, encoding='utf-8') as f:
assert f.read() == 'a: \u2603\n\nb: caf\u00e9\n'


def test_parse_header():
lines = ['# some header', '# is here', '', 'this is not a header']
assert parse_block(lines, header=True) == ['# some header', '# is here']
Expand Down
Loading
Back | FazBrowse Home | New Git URL