Preserve Git filenames in added-file and case checks - #1281
Closed
xiehuanyi wants to merge 3 commits into
Closed
xiehuanyi wants to merge 3 commits into
xiehuanyi wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Git's default core.quotePath=true, check-added-large-files --maxkb=1 mañana.txt returns success for a staged 2 KiB file. The staged path is escaped by Git, so it no longer matches the filename supplied to the hook. The same mismatch lets check-case-conflict miss CAFÉ.py when café.py is already committed.
Read the staged-file and repository-file lists with -z and the existing zsplit helper. This preserves the actual paths, including non-ASCII characters, tabs, and newlines.
Validation:
The tests set core.quotePath=true explicitly. Filenames containing tabs or newlines are skipped on Windows, where those names are invalid; the Unicode cases run on all platforms. This was found during source review of Git filename handling. AI assistance: OpenAI gpt-6.1-sol, xhigh, through Codex.