FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

feat: support nonmonotonic increment by 34j · Pull Request #261 · pre-commit/pre-commit-mirror-maker · GitHub

feat: support nonmonotonic increment - #261

Closed

34j wants to merge 1 commit into

pre-commit:mainfrom

34j:feat/nonlinear-increment

34j commented Mar 1, 2026

Copy link Copy Markdown

No description provided.

feat: support nonlinear increment

f274f66

asottile commented Mar 1, 2026

Copy link Copy Markdown

Member

yeah this clearly doesn't work

asottile closed this Mar 1, 2026

34j commented Mar 1, 2026

Copy link Copy Markdown

Author

It works: https://github.com/34j/mirrors-prettier

34j changed the title feat: support nonlinear increment feat: support nonmonotonic increment Mar 1, 2026

asottile commented Mar 1, 2026

Copy link Copy Markdown

Member

yeah? tests disagree

34j commented Mar 1, 2026 •
edited
Loading

Copy link Copy Markdown

Author

Because I was too lazy to update tests 😅, sorry but thanks for your comment

tests/make_repo_test.py::test_commit_version fails because .version is not updated in _commit_version now (maybe design mistake)
tests/make_repo_test.py::test_make_repo_starting_empty fails because of the added feature

asottile commented Mar 1, 2026

Copy link Copy Markdown

Member

well then you've missed the entire point

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Back | FazBrowse Home | New Git URL