Docs: add note about pre-push hooks not being triggered on ref deletions - #893
Open
whophil wants to merge 1 commit into
Open
Docs: add note about pre-push hooks not being triggered on ref deletions#893whophil wants to merge 1 commit into
whophil wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
asottile
reviewed
Nov 3, 2023
Comment thread
sections/advanced.md
Comment on lines
+185
to
+186
| note: `pre-push` hooks are not triggered for ref deletions. | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
there's a bit more nuance to this than just that -- the variables below imply this is already the case since there must be a from-ref and a to-ref
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Based on the environment variables, I was expecting PRE_COMMIT_TO_REF to be 0000000000000000000000000000000000000000 here, in the case of a ref deletion.
Would you propose an alternate wording, or not documenting this at all?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents behavior described in pre-commit/pre-commit#3050