experimental: Using preact-iso to lazy load components - #1731
Draft
rschristian wants to merge 25 commits into
Draft
experimental: Using preact-iso to lazy load components#1731rschristian wants to merge 25 commits into
rschristian wants to merge 25 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 076d599 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
rschristian
force-pushed
the
experimental/iso-lazy
branch
from
56b3181 to
c1c12e3
Compare
August 13, 2022 08:56
rschristian
commented
Aug 16, 2022
Comment thread
packages/cli/lib/lib/webpack/prerender.js
Outdated
rschristian
force-pushed
the
experimental/iso-lazy
branch
from
6749a8b to
2c2d2e3
Compare
August 18, 2022 00:24
rschristian
force-pushed
the
experimental/iso-lazy
branch
from
2c2d2e3 to
b7b8c1c
Compare
August 18, 2022 03:48
rschristian
commented
Aug 18, 2022
Comment thread
packages/cli/lib/lib/babel-config.js
| ], | ||
| ].filter(Boolean), | ||
| plugins: [ | ||
| require.resolve('@rschristian/babel-plugin-webpack-chunk-name-comments'), |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Webpack is not able to provide names for chunks created with import(). This has two major implications:
- We'll need to create names else we'll see things like 611.chunk.js in the output
- Named chunk groups will not work at all. We currently use them to build the push manifest.
So, I elected to solve this with a Babel plugin. It simply inserts a magic comment to specify the chunk name based upon the import path (import('./routes/foo.js') -> import(/* webpackChunkName: "routes-foo" */ "./routes-foo.js")). Source
The advantage of this approach is that users will not have to manually annotate their imports, we will not have to switch chunks to have named IDs1, we get file names that closely resemble previous output, and we keep named chunk groups.
Hopefully it's not an issue adding my own module. It's quite simple and I'm happy to maintain it if there are any issues.
- We could set Webpack to create chunks with names for IDs and extrapolate file names from there, but that hurts perf and still won't give names to the chunk groups.
Sorry, something went wrong.
rschristian
force-pushed
the
experimental/iso-lazy
branch
3 times, most recently
from
ed27f75 to
bd44545
Compare
August 18, 2022 08:05
rschristian
force-pushed
the
experimental/iso-lazy
branch
2 times, most recently
from
67d6b83 to
c488c3e
Compare
August 25, 2022 06:32
rschristian
force-pushed
the
next
branch
8 times, most recently
from
dfe91b8 to
a14a53a
Compare
December 13, 2022 07:24
rschristian
force-pushed
the
experimental/iso-lazy
branch
2 times, most recently
from
7a8184f to
6653885
Compare
December 14, 2022 00:33
rschristian
commented
Dec 14, 2022
Comment thread
packages/cli/tests/images/build.js
Outdated
| 'es-polyfills.legacy.js': 42690, | ||
| 'dom-polyfills.8a933.legacy.js': 5252, | ||
| 'dom-polyfills.8a933.legacy.js.map': 18836, | ||
| 'es-polyfills.legacy.js': 61323, |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Note to self: 20kb jump seems quite heavy. Thinking something isn't right.
Sorry, something went wrong.
rschristian
force-pushed
the
experimental/iso-lazy
branch
4 times, most recently
from
a70297e to
da85167
Compare
December 15, 2022 00:28
* feat: webpack-v5 * test: Update tests * docs: Updating docs to reflect changes * chore: Removing optimize-plugin local patch
* refactor: Determine CSS module by filename, not directory * docs: Adding changeset * refactor: Project creation pull from templates 'main' branch * test: Updating tests * revert: Accidentally removed log message
* refactor: Extracting out project creation to own package * docs: Adding changeset * refactor: Misc edits to common deps & workspace helper scripts * test: Fixing 'create' test suite * ci: Increase minimum Node version * chore: Fix typos * docs: Update ReadMe instructions * chore: Better (and untaken) package name * docs: Update changeset * test: Update 'create' test suite & build output hashes * docs: Expounding upon changeset
* refactor: Drops support for Preact v8 * docs: Adding changeset
* refactor: Switch over to automatic runtime transform for JSX * test: Removing `h` imports from test suite * docs: Adding changeset
* docs: Adding readme for create-cli * feat: Initial publish * fix: Correcting broken readme links
* refactor: Disable hashing ssr-build's css * docs: Adding changeset * test: Fix unrelated change from altered template
* refactor: Separate internal concepts of config and env * docs: Adding changeset
* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset
* refactor: Better root error handling * refactor: Switch prerender plugin to be async for error gen * refactor: Simplify & improve compilation messages
…isc housekeeping (#1753) * refactor: Drop rimraf for built-in fs.rm * refactor: Drop src argument in build & watch cmds * refactor: Extract info cmd from CLI entrypoint * refactor: Remove update-notifier * refactor: Switch from fs.promises to fs/promises * docs: Adding changeset
* refactor: Merging EJS templates and switcing preferred template extension to .ejs * test: Fixing test suite to reflect latest changes * chore: Cleaning * docs: Updating ReadMe * docs: Adding changeset * refactor: Add error message for <% preact.(head|body)End %>
* refactor: Enables HMR via Prefresh by default * docs: Adding changeset * test: Updating tests to reflect changes to templates
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
force-pushed
the
experimental/iso-lazy
branch
from
dc9b103 to
076d599
Compare
February 2, 2023 12:12
rschristian
force-pushed
the
next
branch
3 times, most recently
from
986f7c7 to
45e8901
Compare
October 10, 2023 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Experimental refactor
Did you add tests for your changes?
Yes
Summary
Deprecates async-loader and automatic route splitting for instead relying on lazy loading, like with preact-iso's lazy().
Code splitting as it previously worked was quite opaque, relying on magic directory names rather than user code.
This should make bundle splitting much more transparent by moving the control into user code.
Does this PR introduce a breaking change?
Yes