Adding eslint configuration - #35
Open
marsitatheultra wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I like the idea, but not sure how is "jsx" a smart default here :P |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah, I've noticed that too... Copy and paste from other docs:
|
Sorry, something went wrong.
itsmunim
reviewed
Dec 24, 2017
Comment thread
.eslintrc.json
| "rules": { | ||
| "semi": 2 | ||
| } | ||
| } No newline at end of file |
Copy link
Copy Markdown
There was a problem hiding this comment.
Add a newline at the end of the file.
Sorry, something went wrong.
phra
requested changes
Dec 31, 2017
phra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
remove jsx support and add a newline at the end of the file.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@stefek99 any update? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good starter project should have smart defaults.
Adding ESLint configuration.