| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for adding this! |
Sorry, something went wrong.
There was a problem hiding this comment.
Here are some comments for the 2D version, please apply the same to the 3D as well, and I will review again. Most of the comments are one-click suggestions, so it shouldn't take too long to integrate most of the feedback.
It would be great if you could integrate this feedback today/tomorrow, so that we can proceed with the next round and merge it before the workshop. I could then include something in the news talk as well! 😉
Sorry, something went wrong.
|
All changes added. |
Sorry, something went wrong.
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
Sorry, something went wrong.
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/question-about-using-overset-mesh-in-fsi-two-way-coupling/1446/4 |
Sorry, something went wrong.
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
Sorry, something went wrong.
|
Ready for re-review @MakisH
Please:
|
Sorry, something went wrong.
This reverts commit 9e011d9.
This reverts commit f6f10ad.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
|
@uekerman I went ahead and fixed most of the trivial issues. Still open:
|
Sorry, something went wrong.
|
I switched the case to use one mesh, and this already helped a lot. The simulation now crashes later, at 0.945: Maybe it is something with the outlet condition now. |
Sorry, something went wrong.
|
By setting the upperWall to zeroGradient, the simulation completes (due to the max-time-windows) at 1.0. |
Sorry, something went wrong.
|
With the current setup, the simulation final crashes at 1.435: I assume we are losing mass somewhere, so maybe we need to check the boundary conditions again. Maybe the zeroGradient for the alpha.water was not such a smart choice in the end. For context, if I use the same solid-calculix as with the perpendicular-flap, then the simulation crashes now at 0.79 with an abnormally deformed flap (shape change). |
Sorry, something went wrong.
|
My last state 9b97b92 does indeed crash, but only at t=1.485. |
Sorry, something went wrong.
That setup is indeed not stiff enough (i.e. the forces here are too high). (The fluid here is different from the one there) |
Sorry, something went wrong.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
|
Latest state here 27d3fd7 crashes at t=1.24. With the old alpha.water (reverting a9cdff1), it crashes at t=0.91. |
Sorry, something went wrong.
|
With a reduced water column height (1/2 height instead of 3/4 height) and a reduced timestep size (2e-3), I can run until t=5. Probably still sensitive, but good enough in my opinion. |
Sorry, something went wrong.
There was a problem hiding this comment.
The simulation now completes for me (for 1s, I trust your runs for 5s) and everything else looks clean.
Thank you for pushing this through the finish line!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR adds a breaking dam 2D and breaking dam 3D test case for multiphase flow of water/air mixture, where a body of water strikes a solid, deformable wall.