test: add missing chain cases - #2462
Open
jorgsowa wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jorgsowa
marked this pull request as draft
March 23, 2026 21:00
jorgsowa
force-pushed
the
test/add-chaining-cases
branch
from
0b14ef7 to
86817c2
Compare
March 23, 2026 21:22
jorgsowa
marked this pull request as ready for review
March 23, 2026 21:22
jorgsowa
force-pushed
the
test/add-chaining-cases
branch
from
86817c2 to
6e9bc76
Compare
March 25, 2026 20:50
czosel
reviewed
Mar 29, 2026
Comment thread
src/util.mjs
|
|
||
| return ( | ||
| parts.length <= depth && | ||
| (node.arguments ?? []).every(isChildSimple) && |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
just for my understanding, does any of the new test cases cover this new bit of logic?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing test cases for method chaining. Those cases hit unvisited code paths.