Repository navigation
Pin GHA dependencies - #9032
Pin GHA dependencies#9032ksen0 merged 2 commits into
Conversation
Sorry, something went wrong.
Vaivaswat2244
left a comment
There was a problem hiding this comment.
lgtm. A small change recommended.
Sorry, something went wrong.
Continuous ReleaseCDN linkPublished PackagesCommit hash: dcdb9f4 Previous deployments3ef0a70This is an automated message. |
Sorry, something went wrong.
Vaivaswat2244
left a comment
There was a problem hiding this comment.
Hi @ulgens, looks good. I verified the hashes independently, all 12 pinned actions across the repo resolve to the commits their version comments claim, and no unpinned refs remain.
We're streamlining the CI work in flight, so I'd like to wait for #9020 to land and re-pin on top of it. Fair warning that it's still Draft, so if it stalls let's revisit rather than sit on this.
Tracking under #9033.
Sorry, something went wrong.
|
@Vaivaswat2244 Thanks for the response. #9020 is a huge PR with hundreds of changed files and it looks like it will take time. We had a similar case with node-20 updates before, and handling those dependencies took months. My recommendation here would be to handle smaller PRs first, and then build the work around what is left - otherwise the process gets stuck. Also, #9020 doesn't change the GHA dependency versions or how they are pinned and it doesn't look like an actual blocker. |
Sorry, something went wrong.
|
That's fair, and it isn't a technical blocker. You're right about that. My reason for holding is rebase direction: if this lands first, 9020 has to absorb the pin changes; if it waits, the rebase falls on this PR instead, which is a single pinact run. Cheaper on this side either way. Point taken on the node-20 precedent though. We're actively pushing to get 9020 merged quickly for exactly this reason — the longer it sits, the more crossover it creates with everything else in the CI area. |
Sorry, something went wrong.
Thanks to https://github.com/suzuki-shunsuke/pinact * Follows the recommended pattern from processing#8674 (comment) * Complementary to processing#8620
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm. Thanks a lot @ulgens for your efforts in this direction. @limzykenneth @ksen0
Sorry, something went wrong.
Thanks to https://github.com/suzuki-shunsuke/pinact
Changes:
PR Checklist