Low contrast between background and foreground colors (text) - #441
Open
shahnoor-khan wants to merge 4 commits into
Open
shahnoor-khan wants to merge 4 commits into
shahnoor-khan wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for your contribution @shahnoor-khan! ⭐️ Tagging @runemadsen for review |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Hi @shahnoor-khan, Thanks for your work on issue #427. A couple of things before we can merge the PR:
Thanks for your help on this! Raphaël |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Hey @SableRaf
|
Sorry, something went wrong.
Stefterv
approved these changes
Jul 26, 2024
Copy link
Copy Markdown
Collaborator
|
@Stefterv Thanks for reviewing this but I think you may have missed the changes I requested in my May 30, 2023 reply :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
worked on issue #427 .
changed the color contrast between background and hover color in footer, so the people with color blindness can also read clearly.
Before the hover color of anchor tag used to be like this:
to this:
Changes made on footer:
to this:
I'm new to open source contributions. Can I work further on this issue #427 to improve the website?
Any advice will be appreciated :)