Feat/#312 describe function to live examples - #477
Open
umangutkarsh wants to merge 2 commits into
Open
umangutkarsh wants to merge 2 commits into
umangutkarsh wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Stefterv
requested changes
Jul 26, 2024
Stefterv
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Hi umangutkarsh,
Thank you for you contribution! Unfortunately creating a function describe is not how you can create a description for a sketch. For an example of how to implement see https://github.com/processing/processing-website/blob/main/content/examples/Basics/Shape/LoadDisplayOBJ/liveSketch.js
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Hi @umangutkarsh! Adding to Stef's comments to suggest looking at this contribution for reference: #447 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue: #312
Added the describe() function to the liveSketch.js examples rather than the .pde files.
Please review the changes and provide some feedback on whether this should be modified.
Hope you'll consider this.