FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added home link on 404 page by praveen-rikhari · Pull Request #515 · processing/processing-website · GitHub

  1. processing
  2. processing-website

Repository navigation

added home link on 404 page - #515

Open
praveen-rikhari wants to merge 1 commit into
processing:mainfrom
praveen-rikhari:praveen/fix-404-page-with-home-link
ConversationCommits (1)ChecksFiles changed
Open

added home link on 404 page#515
praveen-rikhari wants to merge 1 commit into
processing:mainfrom
praveen-rikhari:praveen/fix-404-page-with-home-link

Conversation

praveen-rikhari commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

Now you can see back to home page link on the 404 page

netlify Bot commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for processing-faf822 ready!

Name Link
🔨 Latest commit f5e475a
🔍 Latest deploy log https://app.netlify.com/sites/processing-faf822/deploys/65d4d2ff81179e000891cd14
😎 Deploy Preview https://deploy-preview-515--processing-faf822.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

praveen-rikhari force-pushed the praveen/fix-404-page-with-home-link branch from 2501969 to f5e475a Compare February 20, 2024 16:27
SableRaf requested a review from Stefterv July 12, 2024 11:49

SableRaf commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator

@Stefterv Since you were recently looking at the 404 page maybe you'll have some thoughts about this one.

Stefterv requested changes Jul 12, 2024
View reviewed changes

Stefterv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The code looks good apart from the unnecessarily added package
The language/content probably needs some work

Comment thread i18n/react-intl/es.json

Stefterv Jul 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs a Spanish translation

Comment thread package.json

Stefterv Jul 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unnecessary ?

Comment thread i18n/react-intl/en.json
"inUse": "In use",
"notFound": "NOT FOUND",
"notFoundText": "You just hit a route that doesn't exist... the sadness.",
"backToHome": "back to home",

Stefterv Jul 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Capitalisation?

SableRaf commented Nov 17, 2024

Copy link
Copy Markdown
Collaborator

@praveen-rikhari If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution!

ulgens mentioned this pull request Aug 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Stefterv Stefterv requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL