feat: add Go to source links on reference pages - #712
sharadvc wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Add a footer link on reference pages pointing to the JSON source file in the processing-website repository for the active locale. Fixes processing#704
✅ Deploy Preview for java-processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sorry, something went wrong.
|
Hi, and thanks for your interest in contributing. Please take a moment to review our contribution guidelines. We ask contributors to discuss an issue, get assigned, and only then start working on a PR. We also generally only assign one issue at a time, especially for first time contributors. In this case, the reference .json files are generated from Javadoc in the Processing source code and should generally not be edited directly. Pointing an “edit this page on GitHub” link directly to those generated files does not fix the underlying issue. This is documented in our reference content guide, and was also correctly identified by @ulgens in the issue you referenced. Note: you’ve opened several PRs in quick succession for issues you were not assigned to. Please don’t open further PRs until the proposed approach has been discussed and a maintainer has assigned the issue to you. Thank you. |
Sorry, something went wrong.
Jah-yee
left a comment
There was a problem hiding this comment.
Nice feature — "Go to source" link on reference pages
Adding referenceSourceInfo + goToSource i18n keys and the GoToSource component is a clean approach. A few observations:
- The component is well-isolated (memo + CSS module) ✓
- i18n coverage for en.json and es.json is good ✓
- The paths.js utility likely generates the source URL — make sure it handles all reference types
One suggestion: verify the source URL generation works for all reference types (class/field/function). The CI checks should catch any runtime issues.
Overall LGTM — this improves the contributor experience significantly.
Sorry, something went wrong.
|
Hi @Jah-yee, We've noticed some recent activity from your account, particularly PR reviews, that appears generic and potentially AI-generated. I'd like to take this opportunity to remind you and others reading this (especially potential GSoC candidates) of a few expectations that apply to everyone contributing to our projects (Processing, p5.js, and related repos): Important The Processing Foundation is a non-profit organization, and our open source projects are maintained largely by volunteers. Please be mindful of how your contributions affect others, and respect the time and effort of the people maintaining these projects. Repeatedly disregarding our contribution guidelines may result in temporary or permanent ban. If you're considering applying for GSoC 2027, please be aware that we will reject applications from contributors whose activity has been disruptive or has repeatedly created unnecessary work for maintainers. Please review our policies and guidelines: |
Sorry, something went wrong.
Summary
Add an “edit this page on GitHub” footer on reference pages that links to the locale-specific JSON under content/references/translations/ on main.
Fixes #704