| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
- Add settings.gradle.kts - Update build.gradle.kts
…into issue1099
|
Hi @madhav2348 I have opened #1189 as an example of how this kind of migration should be approached. Would you be interested in adjusting your approach based on that PR? |
Sorry, something went wrong.
|
Sure , I'll be happy to work on that |
Sorry, something went wrong.
|
hi @Stefterv , taking your example as reference, I searched jssc in Maven repository for the serial library : dependencies {
compileOnly(project(":core"))
implementation("org.scream3r:jssc:2.8.0")
}But it doesn't have the method getPortProperties()used in : processing4/java/libraries/serial/src/processing/serial/Serial.java Lines 262 to 265 in 3f36db5 Somehow I found this issue processing/processing@f0cc875 now gohai/java-simple-serial-connector is only a repo, but doesn't have any release or .jar file that I could use Jitpack the solution I thought is
or fork the repo and build/upload the .jar file in release But I need your advice on this: if I'm doing it right! Thankyou |
Sorry, something went wrong.
|
Hi @madhav2348 thank you for flagging this and doing some of the initial research! Looking at the history it seems that the last change reverted it back to a version of https://github.com/java-native/jssc rather than a custom build. Please check if the latest (2.10.2) works or try to find out which version is currently in the repo. Otherwise just use an implementation() tag pointing at the existing .jar and add a TODO pointing to https://github.com/java-native/jssc and create a new issue here in the repo to request migration of jssc to a supported build on maven. |
Sorry, something went wrong.
|
would creating an issue be the correct step ? because it is customized by a previous contributor and its depending for many years |
Sorry, something went wrong.
|
We should create an issue on this repo to start work on creating a more maintainable solution for this jar, either that will be incorporating the project into the repo or creating a downstream repo on the foundation org with the changes. We can figure that out in the new issue |
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you @madhav2348 !
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Migrated the serial library from Ant-based build.xml to Gradle build.gradle.kts
Resolve Issue
Changes
Let me know if further adjustments are needed!