FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactoring `SketchException` to be available outside of `app` by joshgiesbrecht · Pull Request #1196 · processing/processing4 · GitHub

/ processing4 Public

Refactoring SketchException to be available outside of app - #1196

Merged
catilac merged 5 commits into
processing:mainfrom
joshgiesbrecht:SketchException-refactor-redo
Aug 28, 2025
ConversationCommits (5)ChecksFiles changed
Merged

Refactoring SketchException to be available outside of app#1196
catilac merged 5 commits into
processing:mainfrom
joshgiesbrecht:SketchException-refactor-redo

Conversation

joshgiesbrecht commented Aug 1, 2025 •
edited by Stefterv
Loading

Copy link
Copy Markdown
Contributor

Refactored SketchException to live in :app:utils, as per discussion in draft PR #1164. (resubmitted because that draft PR turned into an all-out mess of unrelated commits somehow)

Before merge:

  • Disable/remove GitHub actions related to Ant

Closes #1153

Stefterv marked this pull request as ready for review August 5, 2025 09:02
Stefterv changed the title Sketch exception refactor (new PR) Refactoring SketchException to be available outside of app Aug 5, 2025

Stefterv commented Aug 13, 2025

Copy link
Copy Markdown
Member

Hi @joshgiesbrecht, thank you again for your work on this! I just ran your branch locally and it breaks Android mode since it is looking for the SketchException class but cannot find it within the processing.app. We should keep a SketchException in processing.app and check if it works if it is just an extended version of the processing.utils one.

re-adding a processing.app.SketchException class that extends the new…
7512bc0 
…ly refactored one, so alternate modes don't break.

joshgiesbrecht commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

I think we're good to go now. I wrote a new, very tiny processing.app.SketchException that extends the utils one, so not only does it allow other modes to work but it still plays nicely when testing if something is a processing.utils.SketchException.

Once this is released, I'll submit changes to the other modes so they refer directly to the utils class, and when those are released then I'll come back and delete the extra file. Hopefully. Fingers crossed. 😆

Stefterv commented Aug 15, 2025

Copy link
Copy Markdown
Member

Thank you @joshgiesbrecht! Not sure if the super wrappers are necessary, and could you mark the wrapper class as Deprecated?

joshgiesbrecht commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

Deprecated marked. I didn't expect the wrappers would be necessary either, but Idea complained and said it was a compile problem, so I let it generate them. 🤷

Stefterv requested a review from catilac August 15, 2025 18:14
joshgiesbrecht mentioned this pull request Aug 15, 2025
Closed

joshgiesbrecht commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

Not sure how to connect this PR in github to the issue, but it's resolving issue #1153

SableRaf mentioned this pull request Aug 27, 2025
Closed
catilac reviewed Aug 27, 2025
View reviewed changes
Comment thread app/src/processing/app/SketchException.java
Comment on lines +1 to +2
// temporary band-aid class to support modes which are still looking here for the now-refactored class.
// - josh giesbrecht

catilac Aug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just curious, when would this band-aid be removed?

joshgiesbrecht Aug 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My plan was to submit PRs to the other supported modes to switch them over, once this is released. Then when all existing supported modes are fully switched over this could be deleted.

Stefterv Aug 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Considering we do not know which 3rd party modes/tools have used this class I would expect this stub to be there for quite a while.

catilac Aug 28, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@joshgiesbrecht ah! also i just noticed you had already said this :) could you add a brief comment to the file documenting your plan?

joshgiesbrecht Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@catilac @Stefterv There aren't that many modes to check, but I hadn't considered tools (or libraries, yikes). Is there a 'usual' for deprecated classes that should be planned for? I can update the file with specifics then.

Stefterv Aug 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The thing is, most modes we also do not have a way currently to easily publish new versions, so I suspect this stub to be there for quite a while

catilac requested changes Aug 28, 2025
View reviewed changes

catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me. Please document your plan a bit in the file since it'll be around for a bit, and I'll approve!

catilac approved these changes Aug 28, 2025
View reviewed changes

catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Going to approve. We'll have to come up with a plan for communicating the change to other project maintainers.

catilac merged commit 198f593 into processing:main Aug 28, 2025
6 checks passed
diyaayay mentioned this pull request Aug 6, 2026
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

catilac catilac approved these changes
+1 more reviewer
Stefterv Stefterv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No stack trace or thrower position highlighting on exception

3 participants

Back | FazBrowse Home | New Git URL