FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

General cleanup of `Base` by Stefterv · Pull Request #1299 · processing/processing4 · GitHub

General cleanup of Base - #1299

Merged
Stefterv merged 1 commit into
processing:mainfrom
Stefterv:base-vacuum
Oct 28, 2025
Merged

General cleanup of Base#1299
Stefterv merged 1 commit into
processing:mainfrom
Stefterv:base-vacuum

Conversation

Copy link
Copy Markdown
Member

I started cleaning up some of Base's startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future.

Also removed some of the timing measurement comments

Added some comments to the Processing CLI class

I started cleaning up some of `Base`'s startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future.

Also removed some of the timing measurement comments

Added some comments to the Processing CLI class

// // Check if there were previously opened sketches to be restored
// boolean opened = restoreSketches();
ContributionListing cl = ContributionListing.getInstance();

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is one thing that moved in the sequence, I think this should be okay

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

what is contribution listing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's the helper class that will gather the contributions in the contributions manager from the net

private static void setLookAndFeel() {
try {
// Use native popups to avoid looking crappy on macOS
JPopupMenu.setDefaultLightWeightPopupEnabled(false);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also moved in the sequence

Stefterv requested a review from catilac October 22, 2025 06:30

catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm! merge when ready

Stefterv merged commit 2955cb2 into processing:main Oct 28, 2025
6 checks passed
Stefterv deleted the base-vacuum branch October 28, 2025 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL