Rewrite of the Base.getSettingsFolder() and Platform.getSettingsFolder() - #1335
Merged
catilac merged 4 commits intoDec 5, 2025
Merged
Rewrite of the Base.getSettingsFolder() and Platform.getSettingsFolder()#1335catilac merged 4 commits into
catilac merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
One thing I just realised, that maybe it is a good idea to migrate the settings folders on each platform also to a more modern place (maybe Java can give us a location) |
Sorry, something went wrong.
…lder()` Rewrote both function so they fit into a single file, negating the need for hopping around when looking into what this functionality does. Also rewrote it so it is no longer generates random awt windows through the `Messages` class
- Added the previous settings override in base again - Added a system property to override the settings folder within tests
Introduces logic to detect a preferences.txt file in the same folder as the running executable or jar. If found, settings are loaded from this location, improving portability and allowing users to override default settings without modifying system directories.
Stefterv
force-pushed
the
settings-folder
branch
from
c6c7f97 to
1c27d78
Compare
November 27, 2025 14:13
Stefterv
marked this pull request as ready for review
November 27, 2025 14:13
Copy link
Copy Markdown
Collaborator
|
lgtm! What is a good way for me to test this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It shouldn't really change anything, so if you check the Preferences screen and compare between the local build and 4.4.10 they should be the same! |
Sorry, something went wrong.
catilac
approved these changes
Dec 5, 2025
catilac
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
it works!
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote both functions so they fit into a single file, negating the need for hopping around when looking into what this functionality does. Now all the errors that can occur can be quickly visible and it no longer generates random awt windows through the Messages class
TODO: