FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Publish `org.processing.core.pdf` to maven Central by avinxshKD · Pull Request #1407 · processing/processing4 · GitHub

Publish org.processing.core.pdf to maven Central - #1407

Merged
catilac merged 1 commit into
processing:mainfrom
avinxshKD:publish-pdf
Feb 6, 2026
Merged

Publish org.processing.core.pdf to maven Central#1407
catilac merged 1 commit into
processing:mainfrom
avinxshKD:publish-pdf

Conversation

Copy link
Copy Markdown
Contributor

Adds Maven Central publishing configuration to the PDF library.

  • Added maven-publish plugin
  • Added publishing block for local app repository
  • Added mavenPublishing block with POM metadata
  • Follows same pattern as preprocessor module

Part of #1403

Copy link
Copy Markdown
Contributor Author

@Stefterv hey started with PDF since it was the easiest.
Let me know if this looks good and I'll work on Net/SVG next. thanks

Comment thread java/libraries/pdf/build.gradle.kts Outdated
Stefterv changed the title publish pdf library Publish org.processing.core.pdf to maven Central Feb 4, 2026

Stefterv commented Feb 4, 2026

Copy link
Copy Markdown
Member

Thanks @avinxshKD I added a few comments ;)

Copy link
Copy Markdown
Contributor Author

Thanks @avinxshKD I added a few comments ;)

sure was already on it thanks and welcome :)

Copy link
Copy Markdown
Contributor Author

@Stefterv Updated the coordinates and removed the signing checkk. and
hve skipped the optional migration for this PR to keep it focused on just enabling publishing. Happy to look into a shared plugin in a follow-up refactor for all libraries at once, what do you say?

Copy link
Copy Markdown
Contributor Author

Ready for another look.

Stefterv commented Feb 4, 2026

Copy link
Copy Markdown
Member

The coordinates still need to be fixed, the version should be equal to the processing version, not the version from the library.properties

Copy link
Copy Markdown
Contributor Author

@Stefterv hve updated the version to use rootProject.version so it matches the Processing version as requested

Stefterv commented Feb 4, 2026
edited by SableRaf
Loading

Copy link
Copy Markdown
Member

Hi @avinxshKD, it appears to me that you are overly relying on AI for making your changes, please take a look at the "General note about github comments, reviews, and PRs" section of this message.
If not, please copy the coordinates line directly from my pr, only changing the library name

avinxshKD force-pushed the publish-pdf branch 2 times, most recently from dbf8486 to 6772f84 Compare February 4, 2026 16:09

Copy link
Copy Markdown
Contributor Author

@Stefterv so sorry. Been swamped with exams lately,will be more careful reviewing before pushing.
Made the changes u asked thanks

Stefterv commented Feb 4, 2026

Copy link
Copy Markdown
Member

No worries @avinxshKD thank you for the changes they look great 💙

Copy link
Copy Markdown
Contributor Author

@Stefterv thanks is this ready to merge?? and i have worked for net SVG you can check #1411 thanks

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

@Stefterv so sorry. Been swamped with exams lately,will be more careful reviewing before pushing. Made the changes u asked thanks

Hi @avinxshKD! Just popping in to say, in general everything is pretty low-stakes. So there isn't any intense pressure. This can be a space to take it easy. Though, we really appreciate all the effort you've been making! And if you ever have questions, always feel free to discuss in the PR or in the discord with the others :)

Hope your exams aren't too stressful!

Okay popping out 🍿

Copy link
Copy Markdown
Contributor Author

thanks @catilac, really appreciate ur kind words
Exams are almost done now, so things should be smoother. Thanks again for being so supportive and I’ll definitely ask if I run into anything.

Dont know much about discord tho, but i will try fs <3

Yup see you around, thanks again for chcking in... means alot

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

@avinxshKD would you be able to rebase your branches onto main? We've fixed up some of the build shenanigins and I would like to see your checks passing before merging.

Please let me know if you have any questions about rebasing, and I'll be happy to help!

Copy link
Copy Markdown
Contributor Author

Hey @catilac Just saw this before heading to sleep, perfect timing heh. I’ve rebased both publish-pdf and gradle-net-svg-libs. Goodnight :)
Thanks @catilac @Stefterv

catilac merged commit 8b049ef into processing:main Feb 6, 2026
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL