Resource Leaks in processing/app/Util.java - #1436
Conversation
Sorry, something went wrong.
to put the test in the appropriate directory, id have to java files to grade build configs, because it currently only checks for kotlin tests.
create a temp zip file > create a destination that is a file not a directory (guaranteed exception) -> unzip throws ioexception because it expects a directory not a file -> catch it -> check if the zip file is still open -> if true == leak.
tychedelia
left a comment
There was a problem hiding this comment.
Looks good! We should just either gate or remove the test.
Sorry, something went wrong.
There was a problem hiding this comment.
Probably better to not have a test than a platform specific test.
Sorry, something went wrong.
There was a problem hiding this comment.
Done!
Sorry, something went wrong.
Ive also removed the test since its OS specific, and new code is supposed to be in kotlin.
|
Thanks y'all! Running the tests. I'll go ahead an approve it |
Sorry, something went wrong.
|
@all-contributors please add @SalmaneKhalili for bug-finding, and bug-fixing |
Sorry, something went wrong.
|
I've put up a pull request to add @SalmaneKhalili! 🎉 |
Sorry, something went wrong.
This PR add a simple implementation of what was suggested in #1432, at the moment it was only applied to unzip, i should be able to do the same for the rest of the methods mentioned in the issue, but id like to have feedback on the current way im going about it.