Gradle 9.0.0 - #1459
Closed
catilac wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Stefterv
reviewed
Mar 10, 2026
Comment thread
java/gradle/build.gradle.kts
| tasks.register("writeVersion") { | ||
| // make the version available to the plugin at runtime by writing it to a properties file in the resources directory | ||
| doLast { | ||
| val version = project.version.toString().takeIf { it != "unspecified" } ?: return@doLast |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This will mean that the tests will run w core 4.3.4 instead of the locally build one
Sorry, something went wrong.
catilac
marked this pull request as draft
March 10, 2026 13:55
Closed
Copy link
Copy Markdown
|
Confirming this does run tests, build, etc successfully for me locally (MacOS) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
As mentioned before on discord, unfortunately that is because it skips the failing test rather than solve it |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason github actions is now using Gradle 9.0.0. Unfortunately I missed what exactly changed in that regard.
Locally we were using an earlier version. In this PR I upgraded to Gradle 9.0.0 and have attempted to make it work.
NOTE: I did end up using a combination of Claude code and internet searches to figure this one out.