FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add parsing related unit tests for JSONArray by satindra-r · Pull Request #1484 · processing/processing4 · GitHub

/ processing4 Public

Add parsing related unit tests for JSONArray - #1484

Open
satindra-r wants to merge 1 commit into
processing:mainfrom
satindra-r:JSONArray-tests
ConversationCommits (1)ChecksFiles changed
Open

Add parsing related unit tests for JSONArray#1484
satindra-r wants to merge 1 commit into
processing:mainfrom
satindra-r:JSONArray-tests

Conversation

satindra-r commented Mar 16, 2026

Copy link
Copy Markdown

This PR adds tests to the JSONArray class in core which has some fragile parsing logic.

Solves #1470

catilac requested changes Mar 18, 2026
View reviewed changes

catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, i've added a comment about some stylistic changes!

Comment thread core/test/processing/data/JSONArrayTest.java Outdated
Comment on lines +193 to +196
String json = "[\n" +
"null,\n" +
"null\n" +
"]";

catilac Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why not just make this one string instead of multiple addition operations?

satindra-r Mar 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, I forgot that raw strings were added in java 13. I've made all the json strings into raw strings

Comment thread core/test/processing/data/JSONArrayTest.java Outdated
Comment on lines +204 to +207
String json = "[\n" +
"1,\n" +
"2\n" +
"]";

catilac Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

same as above, this only makes things more difficult to read

catilac commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

@satindra-r thank you so much! i've left some feedback, and i'm triggering the tests

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

catilac catilac requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL