FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

un-revert file permissions fix by catilac · Pull Request #1552 · processing/processing4 · GitHub

/ processing4 Public

un-revert file permissions fix - #1552

Merged
catilac merged 1 commit into
processing:mainfrom
catilac:unbreak_neobrains_fix
Jul 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

un-revert file permissions fix#1552
catilac merged 1 commit into
processing:mainfrom
catilac:unbreak_neobrains_fix

Conversation

catilac commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

catilac commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

@neobrain hi hi can you review?

neobrain reviewed Jul 20, 2026
View reviewed changes

neobrain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

GitHub doesn't let me "approve" this, so my verbal approval will have to do: I approve :)

With 4673b6b reapplied as well, this lets nix build latest Processing again.

catilac commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

Thank you @neobrain i'm going to change the settings, i need to update it to be less....rude

catilac merged commit 93193ef into processing:main Jul 20, 2026
6 checks passed

neobrain commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@catilac Awesome, cheers!

Just to make sure, are you going to re-apply 4673b6b separately as well? :)

btw completely unrelated note, but given Gradle 9 is supported now -- should the nix package update to that already or should we stick to Gradle 8 for now? How about JDK 17?

catilac commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

@neobrain Oo! I should re apply that one. Thanks for pointing it out!
Yes, we are now on Gradle 9. And for now remaining on JDK 17.

We have a flag -PenableWebGPU that when set to true puts us on JDK 25 atm, too. But that is much later down the line

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
neobrain neobrain left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL