Minor improvements to discussion of rebasing. - #1998
Open
buchs wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The branch you rebase "onto" should be the one that changes as a result
michaelblyons
suggested changes
Apr 26, 2025
michaelblyons
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The wording change is wrong. The image change is not wrong, but not really an improvement.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
No particular issues are related to these changes. I have never had much success with rebase (obviously, I merged your main branch into this one!). As I was reading the ProGit book on the subject for the nth time, I realized that the language is misleading as are the diagrams. Here are some minor and early improvements IMO.