FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[proposal] pythonliststyle: Add viewport meta tag by xswordsx · Pull Request #121 · projectdiscovery/simplehttpserver · GitHub

[proposal] pythonliststyle: Add viewport meta tag - #121

Merged
ehsandeep merged 1 commit into
projectdiscovery:mainfrom
xswordsx:proposal/add-viewport-meta-tag-for-pystyle
Jul 26, 2023
Merged

[proposal] pythonliststyle: Add viewport meta tag#121
ehsandeep merged 1 commit into
projectdiscovery:mainfrom
xswordsx:proposal/add-viewport-meta-tag-for-pystyle

Conversation

xswordsx commented Jun 9, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

This makes the rendered HTML appear equally-sized on both mobile and desktop displays.

Before After

Notes

  1. Although this is not present in the original $ python -m http.server command I found that there is a subtle difference between the simplehttpserver and python commands (on Windows at least) with regards to sorting of the listed files & directories, so I decided that it is acceptable for this difference as well.
  2. I saw that the pythonliststyle_test.go imports are not formatted with goimports but I didn't want to clutter the PR.
  3. I was tempted to do the same for the default server, but I saw the the Go FileServer doesn't return full HTML but rather just a <pre> tag. Adding a new handler just for that seemed like it would make the code harder to read for a diminishing gain (not to mention the possible slow-down).

This makes the rendered HTML appear equally-sized on both mobile and
desktop displays
xswordsx changed the title pythonliststyle: Add viewport meta tag [proposal] pythonliststyle: Add viewport meta tag Jun 9, 2023
ehsandeep merged commit 9862845 into projectdiscovery:main Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL