FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Handle empty datapoints in otel exporter by jaydeluca · Pull Request #1898 · prometheus/client_java · GitHub

/ client_java Public

fix: Handle empty datapoints in otel exporter - #1898

Merged
zeitlinger merged 3 commits into
mainfrom
exclude-empty-datapoint
Feb 20, 2026
ConversationCommits (3)ChecksFiles changed
Merged

fix: Handle empty datapoints in otel exporter#1898
zeitlinger merged 3 commits into
mainfrom
exclude-empty-datapoint

Conversation

jaydeluca commented Feb 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

From @dhoard on slack, There was an error in the jmx-exporter project smoke tests:

time=2026-02-16T15:49:03.466Z level=ERROR source=write_handler.go:652 msg="Error appending remote write" component=web err="empty data points. jvm_memory_pool_allocated_bytes is dropped"
2026-02-16 15:49:03.482 | OkHttp http://prometheus:9090/... | WARNING | e1723a08afd7bca35570fd31a7656f59.io.prometheus.metrics.shaded.io_opentelemetry_2_25_0_alpha.exporter.internal.http.HttpExporter | Failed to export metrics. Server responded with HTTP status code 500. Error message: Unable to parse response body, HTTP status message: Internal Server Error

Looking at the documentation for jvm_memory_pool_allocated_bytes... "Only updated after GC, not continuously." Most likely GC hasn't happened, yet the OTel exporter is trying to write the data.

I updated the method to return null when the data points are empty, which is then handled via the addUnlessNull method.

After applying this change locally, I ran the quick test a few times and the error was no longer present.

Handle empy datapoints
00441b0 
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca changed the title Handle empty datapoints in otel exporter fix: Handle empty datapoints in otel exporter Feb 19, 2026
format
2a5cd1f 
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca marked this pull request as ready for review February 19, 2026 16:24
Copilot AI reviewed Feb 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR fixes an issue where the OpenTelemetry exporter was attempting to export metrics with empty data points, causing server errors. The fix addresses a scenario where metrics like jvm_memory_pool_allocated_bytes are registered with label names but have no data points until after garbage collection occurs.

Changes:

  • Added empty data point checks to all MetricDataFactory.create() methods to return null when no data points exist
  • Made the test extension field static to properly share the OpenTelemetryExtension across tests
  • Added comprehensive test case to verify metrics without data points are not exported

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
MetricDataFactory.java Added @Nullable annotations and empty data point checks to all create methods (Counter, Gauge, Summary, Info, StateSet, Unknown)
ExportTest.java Made OpenTelemetryExtension static and added test for metrics without data points

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ...ter-opentelemetry/src/test/java/io/prometheus/metrics/exporter/opentelemetry/ExportTest.java
Copilot AI mentioned this pull request Feb 19, 2026
Closed

This comment was marked as outdated.

Sign in to view
add histogram
32c7e76 
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
zeitlinger approved these changes Feb 20, 2026
View reviewed changes

zeitlinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great!

zeitlinger merged commit 59c8552 into main Feb 20, 2026
15 of 16 checks passed
zeitlinger deleted the exclude-empty-datapoint branch February 20, 2026 15:38
This was referenced Mar 19, 2026
Merged
Merged
zeitlinger added a commit that referenced this pull request Mar 19, 2026
chore: release main (#1965)
3524bcf 
🤖 I have created a release *beep* *boop*
---


<details><summary>1.5.1</summary>

##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-19)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))
</details>

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

---------

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Mar 19, 2026
Closed
Closed
Merged
zeitlinger pushed a commit that referenced this pull request Mar 20, 2026
chore(main): release 1.5.1 (#1979)
b27d2d4 
🤖 I have created a release *beep* *boop*
---


##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-20)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* fix release-please PR title pattern and permissions
([#1978](#1978))
([d737978](d737978))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
zeitlinger zeitlinger approved these changes
fstab Awaiting requested review from fstab fstab is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL