Add DBCP DataSource collector - #363
Closed
edumucelli wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'm not planning on accepting more modules, so I'd suggest hosting this in your own repository. I'd also suggest removing the _num from the metric names as it doesn't add anything, and moving the _min/_max to the end of the metric names. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Alright. Although I think it makes no sense to have another repo just for one specific collector. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @brian-brazil, I needed this DBCP collector and thought it would be a good thing to contribute back, as I am currently using the Guava collector from this lib. As a first PR on this project, I may have missed something. Comments are welcome.