Removed exception handling (test smell) - #567
Merged
brian-brazil merged 1 commit intoAug 13, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Can you add the DCO? |
Sorry, something went wrong.
Signed-off-by: Elvys Soares <eas5@cin.ufpe.br>
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test refactoring.
Problem:
The Exception Handling test smell occurs when explicitly a passing or failing of a test method is dependent on the production method throwing an exception.
Solution:
The use of JUnit's exception handling to automatically pass/fail the test instead of writing custom exception handling code or throwing an exception is encouraged.
Result:
Before:
@Test public void testUnbound() throws IOException { CollectorRegistry registry = new CollectorRegistry(); try { HTTPServer s = new HTTPServer(HttpServer.create(), registry, true); s.stop(); fail("Should refuse to use an unbound HttpServer"); } catch (IllegalArgumentException expected) { } }After:
@Test(expected = IllegalArgumentException.class) public void testRefuseUsingUnbound() throws IOException { CollectorRegistry registry = new CollectorRegistry(); HTTPServer s = new HTTPServer(HttpServer.create(), registry, true); s.stop(); }