Add sanity check for label value - #1012
Merged
csmarchbanks merged 1 commit intoMar 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
andysim3d
force-pushed
the
fix_1011
branch
2 times, most recently
from
770b6a9 to
b226e4d
Compare
March 3, 2024 04:27
csmarchbanks
reviewed
Mar 7, 2024
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you! One tiny request, otherwise 👍
Sorry, something went wrong.
Comment thread
.gitignore
Outdated
csmarchbanks
reviewed
Mar 8, 2024
Comment thread
prometheus_client/metrics.py
Outdated
Add sanity check for label value Signed-off-by: Pengfei Zhang <andysim3d@gmail.com>
csmarchbanks
approved these changes
Mar 9, 2024
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
btimby
pushed a commit
to btimby/client_python
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Pengfei Zhang <andysim3d@gmail.com> Signed-off-by: Ben Timby <btimby@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sanity check when set info's label. value can't be null.
@csmarchbanks ptal.
fix #1011