Support new asgiref - #1081
Open
shadchin wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Alexander Shadchin <shadchin@yandex-team.com>
shadchin
force-pushed
the
new_asgiref
branch
2 times, most recently
from
900e975 to
f86c811
Compare
December 18, 2024 09:06
Signed-off-by: Alexander Shadchin <shadchin@yandex-team.com>
shadchin
force-pushed
the
new_asgiref
branch
from
f86c811 to
afce165
Compare
December 18, 2024 09:19
Signed-off-by: Alexander Shadchin <alexandr.shadchin@gmail.com>
csmarchbanks
reviewed
Jan 7, 2025
Comment thread
tests/test_asgi.py
| self.seed_app(app) | ||
| # Send input with gzip header. | ||
| self.scope["headers"] = [(b"accept-encoding", b"gzip")] | ||
| self.seed_app(app) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is there a reason these are reordered?
Sorry, something went wrong.
Comment thread
tox.ini
| attrs | ||
| {py3.9,pypy3.9}: twisted | ||
| # NOTE: Pinned due to https://github.com/prometheus/client_python/issues/1020 | ||
| py3.9: asgiref==3.7 |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is this going to break for users running on asgiref==3.7?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1020