Migrate from setup.py to pyproject.toml - #1084
Merged
csmarchbanks merged 1 commit intoJan 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
csmarchbanks
force-pushed
the
migrate-to-pyproject
branch
2 times, most recently
from
00438ac to
4ba724f
Compare
January 13, 2025 22:37
csmarchbanks
commented
Jan 17, 2025
Comment thread
pyproject.toml
| license = { file = "LICENSE" } | ||
| requires-python = ">=3.9" | ||
| authors = [ | ||
| { name = "The Prometheus Authors", email = "prometheus-developers@googlegroups.com" }, |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This should be the only substantive change, moving from a specific author to the Promtheus developers as a whole.
Sorry, something went wrong.
csmarchbanks
force-pushed
the
migrate-to-pyproject
branch
from
4ba724f to
8a74be1
Compare
January 17, 2025 18:33
csmarchbanks
commented
Jan 17, 2025
Comment thread
pyproject.toml
|
|
||
| [project] | ||
| name = "prometheus_client" | ||
| version = "0.21.1" |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The version also changed to match the most recent release which had a backport applied to it.
Sorry, something went wrong.
sd2k
reviewed
Jan 18, 2025
sd2k
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks fine to me (although I've never used the pyproject / setuptools build system). One very minor comment!
Sorry, something went wrong.
Comment thread
pyproject.toml
Update the project configuration to use a pyproject.toml file instead of setup.py. This is the preferred tool and will allow easier integration with other tools in the future. We can also get rid of MANIFEST.in as the cache and compiled files are automatically excluded. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
migrate-to-pyproject
branch
from
8a74be1 to
10f22a2
Compare
January 21, 2025 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the project configuration to use a pyproject.toml file instead of setup.py. This is the preferred tool and will allow easier integration with other tools in the future. We can also get rid of MANIFEST.in as the cache and compiled files are automatically excluded.