FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't send an empty HTTP header for /favicon.ico by noselasd · Pull Request #1101 · prometheus/client_python · GitHub

/ client_python Public

Don't send an empty HTTP header for /favicon.ico - #1101

Merged
csmarchbanks merged 1 commit into
prometheus:masterfrom
noselasd:fix_favicon_http_headers
Apr 10, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Don't send an empty HTTP header for /favicon.ico#1101
csmarchbanks merged 1 commit into
prometheus:masterfrom
noselasd:fix_favicon_http_headers

Conversation

noselasd commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Requesting /favicon.ico sends an empty HTTP header:

*   Trying 127.0.0.1:8080...
* Connected to localhost (127.0.0.1) port 8080 (#0)
> GET /favicon.ico HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.88.1
> Accept: */*
>
* HTTP 1.0, assume close after body
< HTTP/1.0 200 OK
< Date: Mon, 07 Apr 2025 14:24:35 GMT
< Server: WSGIServer/0.2 CPython/3.12.9
< :
< Content-Length: 0
<
* Closing connection 0

The empty header right before Content-Length breaks strict proxies/middleware.

Don't send an empty HTTP header.
be40255 
This breaks strict middleware..

Signed-off-by: Nils O. Selåsdal <nos@utel.tech>

csmarchbanks commented Apr 10, 2025

Copy link
Copy Markdown
Member

Thanks!

csmarchbanks merged commit e3902ea into prometheus:master Apr 10, 2025

gravelg commented May 14, 2025

Copy link
Copy Markdown

Hi @csmarchbanks ! How can we request a release including this bugfix? We just ran into the issue and would love if we could take advantage of the fixed code

csmarchbanks commented May 16, 2025

Copy link
Copy Markdown
Member

Sorry about that, I thought I had done one, just released it in v0.22.0

gravelg commented May 18, 2025

Copy link
Copy Markdown

Thank you so much! Really appreciated!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

csmarchbanks csmarchbanks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL