FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BugFix: Skip validating and parsing comment lines early (#1108) by wissamir · Pull Request #1109 · prometheus/client_python · GitHub

/ client_python Public

BugFix: Skip validating and parsing comment lines early (#1108) - #1109

Merged
csmarchbanks merged 1 commit into
prometheus:masterfrom
wissamir:bug_fix_skip_comment_lines_earlier_and_donot_parse
May 28, 2025
ConversationCommits (1)ChecksFiles changed
Merged

BugFix: Skip validating and parsing comment lines early (#1108)#1109
csmarchbanks merged 1 commit into
prometheus:masterfrom
wissamir:bug_fix_skip_comment_lines_earlier_and_donot_parse

Conversation

wissamir commented May 27, 2025

Copy link
Copy Markdown
Contributor

Related to #1108

wissamir force-pushed the bug_fix_skip_comment_lines_earlier_and_donot_parse branch from f359dbd to 12c055a Compare May 27, 2025 09:46
wissamir mentioned this pull request May 27, 2025
Closed

wissamir commented May 27, 2025

Copy link
Copy Markdown
Contributor Author

@csmarchbanks please mind reviewing this

wissamir changed the title BugFix: Skip validating and parsing commit lines early (#1108) BugFix: Skip validating and parsing comment lines early (#1108) May 27, 2025
csmarchbanks reviewed May 27, 2025
View reviewed changes

csmarchbanks left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for both the report and the fix! This looks reasonable to me, but I think the else can be removed from line 347 of your branch and the comment describing that this ignores other comment tokens would be nice to move up here.

You will need to sign the DCO as well before I can merge.

BugFix: Skip validating and parsing comment lines early (prometheus#1108
fed9be0 
)

Signed-off-by: Wissam Abu Ahmad <wabuahma@redhat.com>
wissamir force-pushed the bug_fix_skip_comment_lines_earlier_and_donot_parse branch from 12c055a to fed9be0 Compare May 28, 2025 07:11

wissamir commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Yep, that else branch became unreachable

All sorted out

csmarchbanks approved these changes May 28, 2025
View reviewed changes

csmarchbanks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

csmarchbanks merged commit 938b73e into prometheus:master May 28, 2025

wissamir commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for merging
@csmarchbanks When should we expect a new release to be out?

csmarchbanks commented May 29, 2025

Copy link
Copy Markdown
Member

The next couple of days. I am looking into a couple other issues (namely the change in how licensing looks) to see if I want to include those in a patch release as well.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

csmarchbanks csmarchbanks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL