Fix bug which caused metric publishing to not accept query string parameters in ASGI app - #1125
Merged
csmarchbanks merged 2 commits intoSep 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: hack <hacksparr0w@protonmail.com>
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! Would you be willing to write a test for this please? Or add enough type hinting that it would be caught by mypy.
Sorry, something went wrong.
Signed-off-by: hacksparr0w <hacksparr0w@protonmail.com>
Copy link
Copy Markdown
Contributor
Author
|
I isolated the bug into a test case. Codifying this into type hints would be non-trivial since the used parse_qs function from urllib.parse is not typed and returns Any. |
Sorry, something went wrong.
csmarchbanks
approved these changes
Sep 3, 2025
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _bake_output function in exposition.py expects the params argument to be a dict[str, Any] but the ASGI interface does not handle encoding, thus the parameters are passed in as dict[bytes, Any].