fix: remove space after comma in openmetrics exposition - #1132
Merged
csmarchbanks merged 1 commit intoSep 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
OpenMetrics doesn't allow for spaces between labels and prometheus fails with a parsing error. Removing this fixes UTF8 metrics exposition Signed-off-by: Dominik Süß <dominik@suess.wtf>
theSuess
marked this pull request as ready for review
September 8, 2025 07:52
Copy link
Copy Markdown
Contributor
Author
|
Linting is failing on a file unrelated to this PR |
Sorry, something went wrong.
csmarchbanks
approved these changes
Sep 8, 2025
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMetrics doesn't allow for spaces between labels and prometheus fails with a cryptic parsing error.
Removing this fixes UTF8 metrics exposition