FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix issue parsing double spaces after # HELP/# TYPE by csmarchbanks · Pull Request #1134 · prometheus/client_python · GitHub

Fix issue parsing double spaces after # HELP/# TYPE - #1134

Merged
csmarchbanks merged 1 commit into
masterfrom
fix-parsing-double-spaces
Sep 11, 2025
Merged

Fix issue parsing double spaces after # HELP/# TYPE#1134
csmarchbanks merged 1 commit into
masterfrom
fix-parsing-double-spaces

Conversation

Copy link
Copy Markdown
Member

A regression was reported for 0.22.x where if there are two spaces after HELP or TEXT we would raise a value error. This was caused by having an extra entry in our array of splits due to how we process the splits.

Fixes #1131

csmarchbanks requested a review from ywwg September 11, 2025 19:17
csmarchbanks force-pushed the fix-parsing-double-spaces branch from 78b2026 to fcd94d6 Compare September 11, 2025 19:18
A regression was reported for 0.22.x where if there are two spaces after
HELP or TEXT we would raise a value error. This was caused by having an
extra entry in our array of splits due to how we preocess the splits.

Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks merged commit b3fbbca into master Sep 11, 2025
11 checks passed
csmarchbanks deleted the fix-parsing-double-spaces branch September 11, 2025 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prometheus parser 0.22.0 raises ValueError when parsing HELP, INFO comments with double spaces

2 participants


Back | FazBrowse Home | New Git URL