Add Django exporter (#1088) - #1143
Merged
csmarchbanks merged 1 commit intoJan 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I can't seem to satisfy both isort and flake8_import_order, hence the CI error |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One comment, but generally looks reasonable to me, thanks and apologies for the slow review!
Sorry, something went wrong.
Comment thread
prometheus_client/django/exposition.py
Outdated
Chadys
force-pushed
the
django-support
branch
from
5ed8f28 to
0071a5f
Compare
December 21, 2025 11:42
Signed-off-by: Julie Rymer <rymerjulie.pro@gmail.com>
Chadys
force-pushed
the
django-support
branch
from
0071a5f to
d202251
Compare
December 21, 2025 11:44
Copy link
Copy Markdown
Contributor
Author
|
No worries, volunteer's work knows no clock ;) |
Sorry, something went wrong.
csmarchbanks
approved these changes
Jan 5, 2026
csmarchbanks
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1088
Finally got the time to propose what I had in mind :)
I added a utility view for easy inclusion of a metrics endpoint inside a Django project.
I also added some explanation about django-prometheus and the difference between what it provides and the new view.
I hope the difference is clear that way.