FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: make test suite pass on Windows and Python 3.12+ by MelvinjoseC · Pull Request #1185 · prometheus/client_python · GitHub

/ client_python Public

fix: make test suite pass on Windows and Python 3.12+ - #1185

Merged
csmarchbanks merged 2 commits into
prometheus:masterfrom
MelvinjoseC:master
Jul 24, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: make test suite pass on Windows and Python 3.12+#1185
csmarchbanks merged 2 commits into
prometheus:masterfrom
MelvinjoseC:master

Conversation

MelvinjoseC commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
  • Fix event loop issues in ASGI tests under newer asgiref by wrapping communicator setup in an async coroutine run on the loop.
  • Fix mmap file locking (PermissionError: [WinError 32]) on Windows in multiprocess tests by closing open database handles before unlinking/removing directories.
  • Skip case-sensitive env var deprecation warning assertion on Windows where environment variables are case-insensitive.
  • Conditionally define the parser benchmark test to avoid failure when pytest-benchmark is not installed.

fix: make test suite pass on Windows and Python 3.12+
35924a6 
- Fix event loop issues in ASGI tests under newer asgiref by wrapping communicator setup in an async coroutine run on the loop.
- Fix mmap file locking (PermissionError: [WinError 32]) on Windows in multiprocess tests by closing open database handles before unlinking/removing directories.
- Skip case-sensitive env var deprecation warning assertion on Windows where environment variables are case-insensitive.
- Conditionally define the parser benchmark test to avoid failure when pytest-benchmark is not installed.

Signed-off-by: MelvinjoseC <165891174+MelvinjoseC@users.noreply.github.com>
csmarchbanks reviewed Jun 30, 2026
View reviewed changes

csmarchbanks left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

A few lint errors and such in CI, but generally I am happy with this. Would you also be interested in adding a CI pipeline for windows to avoid regressions? Just one python version is probably enough.

MelvinjoseC commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I've fixed the remaining lint/type issues and added a Windows CI job using Python 3.12. All local checks pass, and GitHub Actions are now running.

csmarchbanks commented Jul 15, 2026

Copy link
Copy Markdown
Member

Thanks! Everything looks good now, but the DCO needs to be signed on your most recent commit.

fix: resolve lint/typing issues and add Windows CI coverage
00c57aa 
Signed-off-by: MelvinjoseC <165891174+MelvinjoseC@users.noreply.github.com>

MelvinjoseC commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I've added the DCO sign-off to the latest commit. The DCO check is now passing. The remaining CI workflow is awaiting maintainer approval.

csmarchbanks approved these changes Jul 24, 2026
View reviewed changes

csmarchbanks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

csmarchbanks merged commit 769b415 into prometheus:master Jul 24, 2026
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

csmarchbanks csmarchbanks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL