Add resctrl collector - #3797
Open
rtreffer wants to merge 1 commit into
Open
rtreffer wants to merge 1 commit into
rtreffer wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rtreffer
force-pushed
the
resctrl-collector
branch
from
c307b92 to
9b420c2
Compare
August 27, 2026 20:05
Copy link
Copy Markdown
Contributor
Author
|
Build error seems unrelate. collector/runit.go:22:2: github.com/prometheus-community/go-runit@v0.1.0: read "https://proxy.golang.org/github.com/prometheus-community/go-runit/@v/v0.1.0.zip": stream error: stream ID 59; INTERNAL_ERROR; received from peer !! command failed: build -o .build/darwin-amd64/node_exporter -ldflags -X github.com/prometheus/common/version.Version=1.12.1 -X github.com/prometheus/common/version.Revision=a7efcaa694b0a9b63576ba5218c51e67c41c9a71 -X github.com/prometheus/common/version.Branch=HEAD -X github.com/prometheus/common/version.BuildUser=root@f0de7527c217 -X github.com/prometheus/common/version.BuildDate=20260827-20:09:54 github.com/prometheus/node_exporter: exit status 1 make: *** [Makefile.common:237: common-build] Error 1 !! the main builder docker image exited unexpectedly: exit status 2 Error: Process completed with exit code 1. The following diff is likely unacceptable at the moment but we need the next tagged procfs version :-) - github.com/prometheus/procfs v0.21.1
+ github.com/prometheus/procfs v0.21.2-0.20260827102831-a87803ee31e3 |
Sorry, something went wrong.
rtreffer
marked this pull request as ready for review
August 27, 2026 20:17
Copy link
Copy Markdown
Member
Need git rebase. |
Sorry, something went wrong.
rtreffer
force-pushed
the
resctrl-collector
branch
from
9b420c2 to
95ef0a8
Compare
September 9, 2026 07:29
Copy link
Copy Markdown
Contributor
Author
|
@dongjiang1989 rebased. diff looks good, procfs is at a tagged version, the Mac OS test needs a rerun. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
U can git commit --amend |
Sorry, something went wrong.
rtreffer
force-pushed
the
resctrl-collector
branch
7 times, most recently
from
afb1527 to
1324402
Compare
September 21, 2026 12:06
Expose the Linux resctrl monitoring counters (Intel RDT, AMD PQoS, ARM MPAM): per L3 domain memory bandwidth (mbm_total_bytes, mbm_local_bytes) and last level cache occupancy (llc_occupancy). Parsing is done by the procfs resctrlfs package (procfs v0.22.0). The collector is disabled by default because the resctrl filesystem must be mounted first (mount -t resctrl resctrl /sys/fs/resctrl). The mountpoint is configurable via --collector.resctrl.path. Counters a CPU does not support (for example mbm_local_bytes on Arm MPAM) or that read "Unavailable" are skipped per sample. The hardware counters wrap; Prometheus treats the wrap as a counter reset, so no correction is applied. Signed-off-by: René Treffer <treffer@measite.de>
rtreffer
force-pushed
the
resctrl-collector
branch
from
1324402 to
45fd980
Compare
September 21, 2026 13:19
Copy link
Copy Markdown
Contributor
Author
|
I think the e2e tests for Mac OS are broken, even on the main branch, PR #3825 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the Linux resctrl monitoring counters (Intel RDT, AMD PQoS, ARM MPAM): per L3 domain memory bandwidth (mbm_total_bytes, mbm_local_bytes) and last level cache occupancy (llc_occupancy). Parsing is done by the procfs resctrlfs package.
The collector is disabled by default because the resctrl filesystem must be mounted first (mount -t resctrl resctrl /sys/fs/resctrl). The mountpoint is configurable via --collector.resctrl.path.
Counters a CPU does not support (for example mbm_local_bytes on Arm MPAM) or that read "Unavailable" are skipped per sample. The hardware counters wrap; Prometheus treats the wrap as a counter reset, so no correction is applied.
Depends on a procfs release that contains the resctrlfs package (prometheus/procfs#862).
Signed-off-by: René Treffer treffer@measite.de
Reviewers
AI disclosure: This code was written with the help of AI.
I have read through the code and verified that it works
Here is a snippet showing the metrics as exported by node_exporter built against prometheus/procfs#862
# HELP node_resctrl_llc_occupancy_bytes Last level cache bytes occupied in this domain. # TYPE node_resctrl_llc_occupancy_bytes gauge node_resctrl_llc_occupancy_bytes{domain="0"} 3.2014336e+07 node_resctrl_llc_occupancy_bytes{domain="1"} 2.3003136e+07 # HELP node_resctrl_memory_bandwidth_bytes_total Bytes moved between the last level cache and memory. scope=total includes remote sockets, scope=local is memory attached to this domain. # TYPE node_resctrl_memory_bandwidth_bytes_total counter node_resctrl_memory_bandwidth_bytes_total{domain="0",scope="local"} 9.866260884132983e+18 node_resctrl_memory_bandwidth_bytes_total{domain="0",scope="total"} 1.8399210738624e+13 node_resctrl_memory_bandwidth_bytes_total{domain="1",scope="local"} 5.010254585456994e+18 node_resctrl_memory_bandwidth_bytes_total{domain="1",scope="total"} 4.003923930496e+12You can use sum by (instance,node) (rate(node_resctrl_memory_bandwidth_bytes_total{scope="total"}[1m])) to get an estimate of the data transferred between memory and CPU.
This is particularly interesting for workloads like CPU inference, in-memory databases or vector databases.
Caveats: The total value is only available if memory access happened. The metric won't be available on every scrape. We could cache the latest value if this is an issue.