Add ExportWriter for combining CSV and NDJSON export pages - #28
Open
jasoncma wants to merge 4 commits into
Open
jasoncma wants to merge 4 commits into
jasoncma wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export consumers currently need their own file writing logic to avoid repeated CSV headers and joined records between pages. ExportWriter accepts ExportPage objects and writes them to a caller owned text stream, preserving record content while emitting the CSV header once.
The writer refuses a format change or changed CSV column order before writing the offending page. It handles quoted multiline headers, header only pages, and missing final newlines. The caller retains ownership of the stream. This is separate from cursor iteration and does not change the API contract or transport.
Validation: all 96 tests pass on the final change, including seven writer tests. Ruff lint and formatting pass, and the updated exports module passes mypy. The full check passed generation, contracts, typing, builds and wheel installation smoke before the final NDJSON newline correction; final focused checks and the full test suite were rerun after that correction. Source distribution installation smoke also passed for that build.
Prepared with AI coding assistance for the Founding GTM Lead application.