fix: preserve Unicode separators in NDJSON exports - #42
Open
MarshalMutisi wants to merge 1 commit into
Open
MarshalMutisi wants to merge 1 commit into
MarshalMutisi wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The NDJSON export decoder used Python's str.splitlines() to separate records. This method also splits on Unicode characters such as U+0085, U+2028, and U+2029, even when they occur inside valid JSON string values.
As a result, valid NDJSON responses could fail to decode, potentially losing exported records and pagination information.
Solution
Changed the NDJSON parser to split only on the LF (\n) record delimiter, preserving Unicode line-separator characters inside JSON strings.
Added a regression test covering U+0085, U+2028, and U+2029 in both synchronous and asynchronous client modes. The test verifies that the string values and pagination cursor are preserved.
Verification
The regression test was also verified to fail before the fix and pass after it.