FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add progress callbacks to review polling by S7012MY · Pull Request #43 · prooflinedev/sdk-python · GitHub

Repository navigation

Add progress callbacks to review polling - #43

Open
S7012MY wants to merge 1 commit into
prooflinedev:mainfrom
S7012MY:feat/review-progress-callback
Open

S7012MY wants to merge 1 commit into
prooflinedev:mainfrom
S7012MY:feat/review-progress-callback

Conversation

S7012MY commented Nov 12, 2026

Copy link
Copy Markdown

Applications that display an in-progress review currently need to duplicate the SDK's polling loop to keep their UI or CI log updated. Add an optional on_update callback to both clients' wait_for_review methods so callers can observe each validated poll, including terminal states, while retaining the existing backoff and request count.

The async client supports synchronous and awaitable callbacks. Callbacks run inline, count toward the existing deadline, and propagate exceptions; the deadline context is restored on failure. Existing callers remain unchanged.

Validation:

  • Nine new HTTP integration cases pass, covering both clients, async callback ordering, no extra requests, callback failures, deadline handling and invalid review IDs.
  • Ruff lint/format, mypy, operation/outcome contracts and wheel/sdist builds pass.
  • Full suite: 148 passed, one existing Windows HTTP deadline case failed once; that exact case passed on isolated rerun.
  • Generation check reports an existing difference in customer_review_detail.py; this PR does not change the schema, templates or generated files.

Prepared with AI coding assistance as an application contribution. Documentation explains callback semantics and includes a usage example.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL