When integrating the SDK into async deployment pipelines, transient network blips or underlying cloud provider 50X errors cause hard crashes. This PR introduces a configurable max_retries parameter (default: 3) to the Proofline client, leveraging httpx native HTTPTransport and AsyncHTTPTransport retry mechanics to improve resiliency out-of-the-box.
Implementation Details
Added max_retries to client initialization.
Injected httpx.HTTPTransport(retries=max_retries) and httpx.AsyncHTTPTransport(retries=max_retries).
Added mock tests in tests/ verifying retry execution on 503 responses.
Testing Notes & CI Baseline
Pytest: pytest passes. Note: test_body_stream_deadline_does_not_turn_authority_into_timeout exhibited flakiness (timing sensitivity), but this behavior is pre-existing on main.
Ruff: ruff check . passes cleanly.
Mypy: The new implementation and tests type-check cleanly. Note: mypy . surfaces 5 pre-existing errors in tests/test_http.py on main, as the local scripts/check.py gate currently only targets proofline and scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When integrating the SDK into async deployment pipelines, transient network blips or underlying cloud provider 50X errors cause hard crashes. This PR introduces a configurable max_retries parameter (default: 3) to the Proofline client, leveraging httpx native HTTPTransport and AsyncHTTPTransport retry mechanics to improve resiliency out-of-the-box.
Implementation Details
Testing Notes & CI Baseline