Fix NDJSON export dataset version validation - #46
Open
angeliqueeumwali wants to merge 1 commit into
Open
angeliqueeumwali wants to merge 1 commit into
angeliqueeumwali wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dataset version validation in decode_export().
Previously, NDJSON responses containing "dataset_version": "1" (a string) were incorrectly accepted because the value was converted to a string before validation.
The decoder now validates dataset versions according to the response format:
Tests
Added a regression test covering both synchronous and asynchronous clients. It verifies that an NDJSON response with a string dataset version raises the expected ProoflineError with type urn:proofline:sdk:invalid-response.
Validation results: