bzlmod: Add MODULE.bazel - #482
Conversation
Sorry, something went wrong.
Signed-off-by: Ryan Northey <ryan@synca.io>
| bazel_dep(name = "rules_license", version = "1.0.0") | ||
| bazel_dep(name = "rules_python", version = "1.7.0") | ||
| bazel_dep(name = "rules_rust", version = "0.68.1") | ||
|
|
There was a problem hiding this comment.
@leonm1 this currently has no llvm toolchain setup - it should have it added as a dev_dependency
it wont prevent consumers from using it - but you will need the toolchain setup in order to test bzlmod
Sorry, something went wrong.
| use_repo(wamr, "com_github_bytecodealliance_wasm_micro_runtime") | ||
|
|
||
| # V8 runtime and its dependencies | ||
| v8 = use_extension("//bazel:extensions.bzl", "v8") |
There was a problem hiding this comment.
ideally we add a v8 (and friends) bzlmod
Sorry, something went wrong.
| ) | ||
|
|
||
| # WasmEdge runtime | ||
| wasmedge = use_extension("//bazel:extensions.bzl", "wasmedge") |
There was a problem hiding this comment.
this file was originally bot generated - this is probably correct - but we dont test this in envoy
Sorry, something went wrong.
|
format issue looks like another bug in rules_rust - it appears to be detecting whether bzlmod is enabled by the presence of MODULE.bazel - which is very much not correct (or at least it needs to enable bzlmod in that case) |
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
No description provided.