FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Assert gRPC calls by alexsnaps · Pull Request #17 · proxy-wasm/test-framework · GitHub

This repository was archived by the owner on Apr 19, 2026. It is now read-only.
/ test-framework Public archive

Assert gRPC calls - #17

Open
alexsnaps wants to merge 3 commits into
proxy-wasm:mainfrom
alexsnaps:gRPC
ConversationCommits (3)ChecksFiles changed
Open

Assert gRPC calls#17
alexsnaps wants to merge 3 commits into
proxy-wasm:mainfrom
alexsnaps:gRPC

Conversation

alexsnaps commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

This is one of the two additions we've done to the framework: support asserting on gRPC calls
Follow up would be reading properties: Kuadrant#1

alexsnaps requested a review from PiotrSikora as a code owner August 11, 2023 10:52

alexsnaps commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

Ugh 🤦 I should test the stuff I cherry-pick from another branch... brb

assert grpc calls
1b82309 
Signed-off-by: Alex Snaps <asnaps@redhat.com>
PiotrSikora reviewed Aug 11, 2023
View reviewed changes

PiotrSikora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any chance that you could add a simple gRPC example to Proxy-Wasm Rust SDK that would exercise the new code paths?

Yes, we want to test the test framework :)

alexsnaps commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yeah. I'll try to find something that avoids pulling things other than basic types tho, to avoid needing protoc - wdyt?

PiotrSikora commented Aug 11, 2023

Copy link
Copy Markdown
Member

Definitely! The simpler the better.

PiotrSikora commented Jul 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

FYI, I've added basic gRPC example in proxy-wasm/proxy-wasm-rust-sdk#248.

PiotrSikora commented Aug 1, 2024

Copy link
Copy Markdown
Member

FYI, I've added basic gRPC example in proxy-wasm/proxy-wasm-rust-sdk#248.

Merged in #23. Could you add coverage for them in this PR? Thanks!

gRPC call example
88bafeb 
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
eguzki mentioned this pull request Nov 29, 2024
Merged

alexsnaps commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

@PiotrSikora thanks to @eguzki I think this has it all now, or do we miss anything?

eguzki commented Dec 9, 2024

Copy link
Copy Markdown

I would also add Kuadrant#6, as it supports assert on GRPC call errors and breaks backward compat regarding the API introduced in this PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
PiotrSikora PiotrSikora left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL