FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Type classes: Omit explicit instance name by gasi · Pull Request #417 · purescript/documentation · GitHub

/ documentation Public

Type classes: Omit explicit instance name - #417

Open
gasi wants to merge 1 commit into
purescript:masterfrom
gasi:patch-1
ConversationCommits (1)ChecksFiles changed
Open

Type classes: Omit explicit instance name#417
gasi wants to merge 1 commit into
purescript:masterfrom
gasi:patch-1

Conversation

gasi commented Feb 14, 2022

Copy link
Copy Markdown

The compiler change to make instance names optional was introduced in v0.14.2:
https://github.com/purescript/purescript/releases/tag/v0.14.2

Type classes: Omit explicit instance name
43c361a 
The compiler change to make instance names optional was introduced in v0.14.2:
https://github.com/purescript/purescript/releases/tag/v0.14.2
JordanMartinez approved these changes Feb 14, 2022
View reviewed changes

JordanMartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. However, I'm wondering if we should state that instance names are optional and provide an example.

AFAIK, removing instance names altogether hasn't been discussed and they're still used in core/contrib/web/node libraries. A new user might wonder if they are some advanced syntax or something.

thomashoneyman commented Feb 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Yea, these instances are preserved across core / contrib until 0.15 because it’s a breaking change to remove them (it means losing support for 0.14.0 and 0.14.1). I think it’d be preferable to mention they’re optional.

I believe there’s another docs page where we talk about instance names being used for readable JavaScript that we could crib from?

JordanMartinez commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

This hasn't been merged because feedback hasn't been addressed. It wouldn't take much to finish it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
JordanMartinez JordanMartinez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL