Allow tabs as indentation - #4580
Draft
artemisSystem wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
For a quick test, i cloned purescript-lists and used vscode to change the indentation to tabs. After doing that for all the files, it still compiled just fine. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow tabs as indentation in purescript source files. Implemented as suggested by @rhendric in this comment. Only difference is that i didn't add HDelta|VDelta, i added PosDelta, which is as VDelta was described. I found it redundant to have a HDelta when that could instead be represented as a "VDelta" with 0 lines and 0 tabs.
I was unsure about the usage of ! and UNPACK pragmas in data declarations, so let me know if any of those should be done differently.
Marked as draft because i have not implemented tests yet, but the code itself is ready for review.
Closes #3939
Checklist: