Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Just to be sure what this fixes. Is this a fix for that bug where you have a Nothing say, that isn't at the top level, and the compiler tries to infer Maybe a when it should infer Maybe String or something? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, in inference mode, the typechecker will now not infer the polymorphic type forall a. Maybe a for the expression Nothing, for example. In checking mode, nothing has changed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Cool. Thanks! |
Sorry, something went wrong.
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@garyb @joneshf Could you please review? test-everything passes, and the code in #814 now builds.