FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bower version resolutions by owickstrom · Pull Request #11 · purescript-hyper/purescript-hypertrout · GitHub

Bower version resolutions - #11

Merged
nsaunders merged 1 commit into
masterfrom
resolutions
May 20, 2019
Merged

Bower version resolutions#11
nsaunders merged 1 commit into
masterfrom
resolutions

Conversation

Copy link
Copy Markdown
Collaborator

Noticed master wasn't compiling anymore. Not sure if these resolutions make sense. @NicholasSaunders any input on the conflicting versions?

Copy link
Copy Markdown
Contributor

In what environment did you observe the compilation error? I’ve had to blow away my bower_components directory (which also means the output directory) at times for Bower not to prompt about version conflicts. But if the environment was clean then I definitely probably made a mistake somewhere... I will certainly look into it when I get back to my computer. Thanks @owickstrom.

nsaunders commented May 12, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

OK, I think the issue you encountered @owickstrom was the result of upstream version conflicts. If purescript-hyper/hyper#76 seems reasonable to you, then we could probably resolve this by releasing a new 0.9.1 version of Hyper, with no changes required here. What do you think?

Copy link
Copy Markdown
Collaborator Author

@NicholasSaunders That sounds good. 👍

Copy link
Copy Markdown
Collaborator Author

The error showed up when I merged your PR, in the Travis CI build. Reproduced it locally.

Copy link
Copy Markdown
Contributor

A quick update... After removing the explicit purescript-argonaut-* dependencies from Hyper and cutting a new release, this issue persists (although I still think this was probably a good change). However, I determined that running this in a clean directory results in a version conflict:

bower install purescript-argonaut@^5.0.0 purescript-argonaut-generic

So I think we probably still need the resolutions for now. I actually found that the project builds (including examples) and all tests pass given these resolutions (later versions):

+  },
+  "resolutions": {
+    "purescript-argonaut-core": "^5.0.0",
+    "purescript-record": "^2.0.0",
+    "purescript-argonaut-codecs": "^6.0.2",
+    "purescript-foreign-object": "^2.0.0",
+    "purescript-typelevel-prelude": "^4.0.0"

@owickstrom, would you want to update your resolutions, or should we merge as-is?

nsaunders merged commit ec6de66 into master May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL